Repository navigation
ci: CI check for hand-started publish, Slack out of the release-key job - #345
Merged
Merged
Conversation
From the CLI's security review: a hand-started Publish SDK now needs a green CI run on main for that commit, and Merge SDK's Slack step (a container action) runs in its own job instead of the one holding the release App key. Pins sdk-release to c8db692. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Human validation is still required because the changes affect secret-bearing release workflows, protected-environment isolation, GitHub Actions permission and event behavior, and externally pinned actions that cannot be fully exercised here.
No open issues 🎉
What changed in this PR
This pull request hardens SDK release automation by requiring successful CI for manually triggered publishes and isolating Slack notifications from the release credentials job.
Changes:
- Adds an Actions API check requiring a successful push-triggered CI run for the selected
maincommit. - Updates the pinned
gr4vy/sdk-releaseaction to commitc8db692. - Moves merge-time Slack notifications into a separate job using outputs from the release decision job.
| File | Description |
|---|---|
.github/workflows/sdk_publish.yaml |
Adds the manual-publish CI gate and updates the release action pin. |
.github/workflows/sdk_merge.yaml |
Exposes release-bot outputs and isolates Slack notification handling from release credentials. |
Review effort: Lite
…rson) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sdk_publish.yaml,sdk_merge.yaml, sdk-release pingr4vy/sdk-releasef956131 →4d17bbf(#15–#17: dependency downgrades, floating versions and non-version text go to a person)Brings the release hardening the CLI got (gr4vy-cli#186) to this SDK:
🤖 Generated with Claude Code